CLDR-17388 v45 update logKnownIssues #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- from unrelated and closed CLDR-10765 to new CLDR-17397
- from closed CLDR-15034 to new CLDR-17398
srl295
requested review from
macchiati,
btangmu,
pedberg-icu and
DraganBesevic
- remove CLDR-10120 "fixed by JDK update" - remove CLDR-7121 - commented out - fix ICU-21241 to CLDR-17189
- remove additional commented-out or now-passing issues
srl295
commented
Feb 23, 2024
Comment on lines
+1588
to
+1595
| // TODO 17397: remove isKnownIssue and the if around errln when the logknown issue | ||
| // goes away. | ||
| final boolean skipKnownIssue = | ||
| currency.equals("ANG") | ||
| && isoCountries.isEmpty() | ||
| && cldrCountries.equals(Set.of("CW", "SX")) | ||
| && logKnownIssue("CLDR-17397", "Mismatched codes " + cldrCountries); | ||
| if (!skipKnownIssue) { |
There was a problem hiding this comment.
this is now a very specific logKnownIssue. It won't mask future issues, even if we somehow don't work on CLDR-17397
macchiati
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17388
update two logKnownIssues from closed to open tickets.
ALLOW_MANY_COMMITS=true